Forwarding headers fixes/improvements #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seancribbs
approved these changes
Jun 16, 2023
|
Rebased to resolve conflict with tuple-module removal. |
Resolves webmachine#315. `wrq:peer` is documented as returning the client IP. That's the first non-local element in the first X-Forwarded-For header. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For `webmachine_request:get_sock` continues to return the last entry in X-Forwarded-For. So basically "get_sock" is "how is this server connected to the internet" and "get_peer" is "how is this client connected to the internet"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch started with a fix for #315.
webmachine_request:get_peernow returns the earliest non-private IP, which is the one closest to the client, andwebmachine_request:get_sockreturns the latest non-private IP, which is the one closest to the server.While making the first change, I noticed that IPv6 wasn't well-supported. Localhost, link-local, and private v4 IPs translated to v6 IPs are now treated as private by
get_peerandget_sock.Finally, support is added for the standardized
Forwardedheader.X-Forwarded-Foris checked only if no answer was found inForwarded.This is all implemented based on reading specs and other guides. I don't have a proper setup to test the behaviors of real-world proxies.