Use unsigned long for size related options of conv2d, convTranspose2d and pooling operations #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no use cases for negative values of these attributes including: - MLConv2dOptions: padding, strides, dilations and groups. - MLConvTranspose2dOptions: padding, strides, dilations, outputPadding, outputSizes and groups. - MLPool2dOptions: windowDimensions, padding, strides, dilations and outputSizes. fix webmachinelearning#269
anssiko
approved these changes
Sep 8, 2022
wacky6
approved these changes
Sep 9, 2022
huningxin
changed the title
|
@wchao1115 can we merge this? |
|
@wchao1115 gentle ping, PTAL. |
wchao1115
approved these changes
Dec 16, 2022
|
Thanks again @wchao1115! @huningxin I addressed the merge conflict. PTAL and feel free to merge when you're good. @BruceDai for wpt test alignment. |
|
@anssiko Thanks for your reminder, I got it. |
|
Thanks for the review and approval. Also thanks @anssiko for the rebasing. I am going to merge it. |
github-actions bot
added a commit
that referenced
this pull request
Dec 20, 2022
SHA: 5a4e73e Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 18, 2023
This CL implements the WebNN spec changes [1] and [2] that fix the data type of attributes for MLConv2dOptions, MLPool2dOptions and MLResample2dOptions by using unsigned integers instead of signed integers. For those attributes, the negative values are not meaningful. The MLGraphBuilder, MLGraphBuilderTest and MLGraphXnnpack are updated according to this IDL change. [1]: webmachinelearning/webnn#294 [2]: webmachinelearning/webnn#306 Bug: 1273291 Change-Id: Ic7aa42ff20676b959695e66608d3254ce368c7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4164044 Reviewed-by: Jiewei Qian <qjw@chromium.org> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1093807}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no use cases for negative values of these attributes including:
fix #269
@wchao1115 @anssiko @wacky6 @miaobin, PTAL. Thanks!
Preview | Diff