Add an option to always display vertical scrollbar #1092

webmin · Apr 1, 2018 · 9e1ea9e · 9e1ea9e
1 parent 03a6945
commit 9e1ea9e
Show file tree

Hide file tree

Showing 24 changed files with 66 additions and 38 deletions.
diff --git a/authentic-init.pm b/authentic-init.pm
@@ -63,31 +63,32 @@ sub settings_filter
 sub settings_default
 {
     my %c;
-    $c{'settings_font_family'}                  = '0';
-    $c{'settings_navigation_color'}             = 'blue';
-    $c{'settings_background_color'}             = 'gainsboro';
-    $c{'settings_button_tooltip'}               = 'true';
-    $c{'settings_hide_top_loader'}              = 'false';
-    $c{'settings_animation_left'}               = 'true';
-    $c{'settings_animation_tabs'}               = 'true';
-    $c{'settings_sysinfo_link_mini'}            = 'false';
-    $c{'settings_show_night_mode_link'}         = 'true';
-    $c{'settings_theme_options_button'}         = 'true';
-    $c{'settings_leftmenu_button_refresh'}      = 'false';
-    $c{'settings_hotkeys_active'}               = 'true';
-    $c{'settings_hotkey_toggle_modifier'}       = 'altKey';
-    $c{'settings_hotkey_toggle_key_webmin'}     = 'w';
-    $c{'settings_hotkey_toggle_key_virtualmin'} = 'v';
-    $c{'settings_hotkey_toggle_key_cloudmin'}   = 'c';
-    $c{'settings_hotkey_toggle_key_usermin'}    = 'u';
-    $c{'settings_hotkey_toggle_key_webmail'}    = 'm';
-    $c{'settings_hotkey_shell'}                 = 'k';
-    $c{'settings_hotkey_sysinfo'}               = 'i';
-    $c{'settings_hotkey_toggle_slider'}         = 'n';
-    $c{'settings_hotkey_favorites'}             = 'f';
-    $c{'settings_hotkey_focus_search'}          = 's';
-    $c{'settings_hotkey_reload'}                = 'r';
-    $c{'settings_hotkey_toggle_key_night_mode'} = 'l';
+    $c{'settings_font_family'}                        = '0';
+    $c{'settings_navigation_color'}                   = 'blue';
+    $c{'settings_background_color'}                   = 'gainsboro';
+    $c{'settings_right_page_hide_persistent_vscroll'} = 'true';
+    $c{'settings_button_tooltip'}                     = 'true';
+    $c{'settings_hide_top_loader'}                    = 'false';
+    $c{'settings_animation_left'}                     = 'true';
+    $c{'settings_animation_tabs'}                     = 'true';
+    $c{'settings_sysinfo_link_mini'}                  = 'false';
+    $c{'settings_show_night_mode_link'}               = 'true';
+    $c{'settings_theme_options_button'}               = 'true';
+    $c{'settings_leftmenu_button_refresh'}            = 'false';
+    $c{'settings_hotkeys_active'}                     = 'true';
+    $c{'settings_hotkey_toggle_modifier'}             = 'altKey';
+    $c{'settings_hotkey_toggle_key_webmin'}           = 'w';
+    $c{'settings_hotkey_toggle_key_virtualmin'}       = 'v';
+    $c{'settings_hotkey_toggle_key_cloudmin'}         = 'c';
+    $c{'settings_hotkey_toggle_key_usermin'}          = 'u';
+    $c{'settings_hotkey_toggle_key_webmail'}          = 'm';
+    $c{'settings_hotkey_shell'}                       = 'k';
+    $c{'settings_hotkey_sysinfo'}                     = 'i';
+    $c{'settings_hotkey_toggle_slider'}               = 'n';
+    $c{'settings_hotkey_favorites'}                   = 'f';
+    $c{'settings_hotkey_focus_search'}                = 's';
+    $c{'settings_hotkey_reload'}                      = 'r';
+    $c{'settings_hotkey_toggle_key_night_mode'}       = 'l';
 
     return %c;
 }

diff --git a/authentic-lib.pm b/authentic-lib.pm
@@ -2080,6 +2080,8 @@ sub _settings
             '0',
             'settings_cm_editor_palette',
             'monokai',
+            'settings_right_page_hide_persistent_vscroll',
+            'true',
             'settings_hide_top_loader',
             'false',
             'settings_animation_left',
@@ -2091,7 +2093,7 @@ sub _settings
             'settings_global_passgen_format',
             '12|a-z,A-Z,0-9,#',
             '__',
-            _settings('fa', 'bell',    &Atext('settings_right_notification_slider_options_title')),
+            _settings('fa', 'bell', &Atext('settings_right_notification_slider_options_title')),
             'settings_side_slider_enabled',
             'true',
             'settings_side_slider_fixed',
@@ -3163,7 +3165,8 @@ sub content
     print_favorites();
 
     # Content
-    print '<div id="content" class="__page">' . "\n";
+    print '<div id="content" class="__page' .
+      ($__settings{'settings_right_page_hide_persistent_vscroll'} eq 'false' ? ' fvscroll' : undef) . '">' . "\n";
 
     print '  <div class="container-fluid col-lg-10 col-lg-offset-1" data-dcontainer="1"></div>' . "\n";
 }

diff --git a/lang/ca.UTF-8 b/lang/ca.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/cz.UTF-8 b/lang/cz.UTF-8
@@ -828,3 +828,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/da.UTF-8 b/lang/da.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/de.UTF-8 b/lang/de.UTF-8
@@ -820,3 +820,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/en.UTF-8 b/lang/en.UTF-8
@@ -826,3 +826,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/es.UTF-8 b/lang/es.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/fr.UTF-8 b/lang/fr.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/id.UTF-8 b/lang/id.UTF-8
@@ -831,3 +831,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/it.UTF-8 b/lang/it.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/ja_JP.UTF-8 b/lang/ja_JP.UTF-8
@@ -826,3 +826,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/nl.UTF-8 b/lang/nl.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/no.UTF-8 b/lang/no.UTF-8
@@ -686,3 +686,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/pl.UTF-8 b/lang/pl.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/pt.UTF-8 b/lang/pt.UTF-8
@@ -829,3 +829,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/ro_RO.UTF-8 b/lang/ro_RO.UTF-8
@@ -827,3 +827,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/ru.UTF-8 b/lang/ru.UTF-8
@@ -832,3 +832,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/sq.UTF-8 b/lang/sq.UTF-8
@@ -840,3 +840,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/sv.UTF-8 b/lang/sv.UTF-8
@@ -826,3 +826,4 @@ theme_xhred_global_settings=Inställningar
 theme_xhred_tooltip_side_slider_pinned=Fäst/ta bort sidomenyn
 settings_side_slider_fixed_toggle=Visa växla fäst/ta bort
 settings_side_slider_fixed_toggle_description=Detta alternativ visar en växlaknapp på nedersta raden i sidomenyn som tillåter dig att växla funktionen direkt, men bara om villkoren i tidigare alternativ är uppfyllda
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/lang/zh_CN.UTF-8 b/lang/zh_CN.UTF-8
@@ -845,3 +845,4 @@ theme_xhred_global_settings=Settings
 theme_xhred_tooltip_side_slider_pinned=Pin/unpin side slider
 settings_side_slider_fixed_toggle=Show pin/unpin toggle
 settings_side_slider_fixed_toggle_description=This option will display the toggle, in the side slider, at the bottom row, allowing to toggle its visibility on the fly, if conditions in previous option are met
+settings_right_page_hide_persistent_vscroll=Hide persistent vertical scrollbar
diff --git a/settings-user.cgi b/settings-user.cgi
@@ -46,6 +46,11 @@ print ui_table_row($Atext{'settings_cm_editor_palette'},
                                                     'settings_cm_editor_palette'
                    ));
 
+print ui_table_row($Atext{'settings_right_page_hide_persistent_vscroll'},
+                   ui_yesno_radio('settings_right_page_hide_persistent_vscroll',
+                                  $__settings{'settings_right_page_hide_persistent_vscroll'},
+                                  "true", "false"
+                   ));
 print ui_table_row(undef, '<b>' . $Atext{'settings_right_navigation_menu_title'} . '</b>', 2);
 
 print ui_table_row($Atext{'settings_button_tooltip'},

diff --git a/unauthenticated/css/bundle.min.css b/unauthenticated/css/bundle.min.css
diff --git a/unauthenticated/js/bundle.min.js b/unauthenticated/js/bundle.min.js