Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minserv option to destroy session on IPs mismatch #244

Closed
iliajie opened this issue Aug 24, 2015 · 5 comments
Closed

Minserv option to destroy session on IPs mismatch #244

iliajie opened this issue Aug 24, 2015 · 5 comments

Comments

@iliajie
Copy link
Collaborator

iliajie commented Aug 24, 2015

It would be very important to have an option in Webmin/Usermin configuration to destroy the session data and force user to provide login credential over again, if initial IP address wouldn't match the latter one. Now, if you login to Webmin using one IP, then, connect to the internet having another IP, and reload the page, - Webmin says nothing! It's possible thread in case session data is stolen/copied in some way.

It would also be user friendly to have a message of why they have to enter their login data again (like it's already done with different messages). Makes perfect sense to me!

Could you please do it?

@iliajie iliajie changed the title Minserv options to destroy session on IPs mismatch Minserv option to destroy session on IPs mismatch Aug 24, 2015
@jcameron
Copy link
Collaborator

This wouldn't work too well for users connecting via a proxy service that runs on multiple machines - their traffic might be coming from several different IPs, despite being from a single user.

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 24, 2015

Yes, I realize this. But it would be optional and off be default. This is great benefit for users with static IPs! ;)

@jcameron
Copy link
Collaborator

Ok, I will add this as an option.

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 25, 2015

👍

@iliajie
Copy link
Collaborator Author

iliajie commented Aug 25, 2015

Thank you, Jamie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants