Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase specificity of regex to avoid problems with new output from certbot/letsencrypt client #437

Merged
merged 1 commit into from
Oct 9, 2016

Conversation

deserted
Copy link
Contributor

@deserted deserted commented Oct 9, 2016

Some changes in the output of certbot/letsencrypt mean that the general regex is matching lines like /etc/letsencrypt/keys/0037_key-certbot.pem - this is resulting in the directory for finding cert.pem, fullchain.pem and privkey.pem is incorrect - they are looking up in /etc/letsencrypt/keys/ instead of /etc/letsencrypt/live/{domain}/.

being this only applies when $letsencrypt_cmd has been set, it should be safe to push it to /etc/letsencrypt/(live|archive) as a hard folder match, to avoid this issue.

@leotm
Copy link

leotm commented Dec 14, 2016

Symbolic link fine for the live folder?
Permission denied for hard links.

@jcameron
Copy link
Collaborator

@leotm - are you saying that you're getting permission denied errors because Let's Encrypt is creating a hard-linked certificate file?

@leotm
Copy link

leotm commented Dec 15, 2016

Solved it, had my /etc/nginx/sites-enabled/default server block configured wrong, giving the failed output after running letsencrypt (so it wasn't creating the /etc/letsencrypt/live/ folder).

Thought I needed to link /etc/letsencrypt/keys/ to /etc/letsencrypt/live/, for some reason, my b.

Thanks for the quick reply.

@ndstate
Copy link

ndstate commented Feb 25, 2017

Hello, I am running into the issue SSLCertificateFile: file '/etc/letsencrypt/live/.../fullchain.pem' does not exist or is empty when I run apachectl -S. Is there a fix? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants