Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce own exception for assertions #222

Merged
merged 3 commits into from
Mar 7, 2021

Conversation

andrew-demb
Copy link
Contributor

May be helpful for catching only exceptions related to this package without the risk to catch another not related exceptions.

Ref #202

Copy link
Contributor

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but we really need to put a nail on the coffin of exception overrides (still possible, really bad idea, and to be deprecated/removed).

@Nyholm
Copy link
Collaborator

Nyholm commented Jan 16, 2021

Hm.. Interesting. I was sure we already did this.

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it!

I was thinking of this #19.

I am happy with this PR.

@Nyholm
Copy link
Collaborator

Nyholm commented Jan 18, 2021

Could you please rebase this PR?

@andrew-demb
Copy link
Contributor Author

Rebased.

@Nyholm
Copy link
Collaborator

Nyholm commented Jan 18, 2021

Thank you.

Im 👍

@Nyholm
Copy link
Collaborator

Nyholm commented Mar 7, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants