Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitattributes #251

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Update .gitattributes #251

merged 1 commit into from
Jun 19, 2021

Conversation

williamdes
Copy link
Contributor 

Found: phpMyAdmin-5.2.0-dev-all-languages/vendor/webmozart/assert/.editorconfig
Found: phpMyAdmin-5.2.0-dev-all-languages/vendor/webmozart/assert/.github/
Found: phpMyAdmin-5.2.0-dev-all-languages/vendor/webmozart/assert/.github/workflows/
Found: phpMyAdmin-5.2.0-dev-all-languages/vendor/webmozart/assert/.github/workflows/ci.yaml
Found: phpMyAdmin-5.2.0-dev-all-languages/vendor/webmozart/assert/.php_cs
Found: phpMyAdmin-5.2.0-dev-all-languages/vendor/webmozart/assert/psalm.xml

Nyholm
Nyholm approved these changes Jun 19, 2021
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit b419d64 into webmozarts:master Jun 19, 2021
@glensc
Copy link

glensc commented Oct 25, 2021

@williamdes is there a tool you used to test for excess files (non-sources)?

glensc added a commit to eventum/eventum that referenced this pull request Oct 25, 2021
@glensc
Skip .editorconfig from all vendor
eff569f 
refs:
- webmozarts/assert#251 (comment)
@williamdes
Copy link
Contributor Author

@williamdes is there a tool you used to test for excess files (non-sources)?

Yes, our cleanup script at phpMyAdmin: https://github.com/phpmyadmin/phpmyadmin/blob/QA_5_1/scripts/check-release-excludes.sh

And some similar list at https://github.com/code-lts/doctum/blob/1c7724639a3dbd806de0a4c59ebfee920db038b8/scripts/phar-generator-script.php#L99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamdes @glensc @Nyholm