Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PHP 7.1 compatibility #45

Merged
merged 3 commits into from
Jan 29, 2018
Merged

Conversation

bcremer
Copy link
Contributor

@bcremer bcremer commented Apr 10, 2017

Test PHP 7.1 compatibility

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR

composer.json Outdated
@@ -10,7 +10,7 @@
}
],
"require": {
"php": "^5.3.3 || ^7.0"
"php": "^5.3.3 || ^7.0 || ^7.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. PHP does not follow Semver but this is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed.

@TomasVotruba
Copy link

What needs to be done here?

@Nyholm
Copy link
Collaborator

Nyholm commented Jan 29, 2018

Thank you for this PR. I will merge it as soon as Travis is happy

@Nyholm Nyholm merged commit 0df1908 into webmozarts:master Jan 29, 2018
@TomasVotruba
Copy link

Blast from the past 🚀

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants