-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test PHP 7.1 compatibility #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR
composer.json
Outdated
@@ -10,7 +10,7 @@ | |||
} | |||
], | |||
"require": { | |||
"php": "^5.3.3 || ^7.0" | |||
"php": "^5.3.3 || ^7.0 || ^7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. PHP does not follow Semver but this is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, removed.
What needs to be done here? |
Thank you for this PR. I will merge it as soon as Travis is happy |
Blast from the past 🚀 Thanks |
Test PHP 7.1 compatibility