Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support and migration to stable CI system #24

Merged
merged 17 commits into from
Jan 14, 2021

Conversation

Ocramius
Copy link
Collaborator

@Ocramius Ocramius commented Jan 14, 2021

This is #21, but with added CI and maintenance tools that I need to take over maintenance here

Fixes #21
Fixes #17

@Ocramius Ocramius added this to the 4.2.0 milestone Jan 14, 2021
@Ocramius Ocramius self-assigned this Jan 14, 2021
@Ocramius
Copy link
Collaborator Author

Overall looks good: will need to adjust repo configs to merge and later add release automation, for which I still need admin access (pending)

composer.json Outdated Show resolved Hide resolved
…version constraint

Co-authored-by: Martins Sipenko <martins.sipenko@gmail.com>
@martinssipenko
Copy link
Contributor

martinssipenko commented Jan 14, 2021

A bunch of canned CI badges could be removed from README.md.

Copy link
Contributor

@martinssipenko martinssipenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

.github/workflows/phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/phpunit.yml Show resolved Hide resolved
.github/workflows/phpunit.yml Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
@Ocramius Ocramius changed the base branch from master to 4.2.x January 14, 2021 18:07
@Ocramius Ocramius merged commit d156180 into 4.2.x Jan 14, 2021
@Ocramius Ocramius deleted the feature/php-8-support branch January 14, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project still active?
5 participants