Don't unnecessarily invoke type loader when printing schema #1336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before #1303 , the type loader was not invoked when printing the schema and not mutation or subscription is defined.
This brings back the previous behaviour in this regard.
I'm not sure what is really wanted here, it was discovered as feedback in the preparation for graphql-laravel for the graphql-php v15 upgrade in rebing/graphql-laravel#953 (comment) and we added a test case which did not trigger the typeloader in v14 ( rebing/graphql-laravel#995 , though at that point it wasn't yet clear what's going on).
It's not a big issue, but I figured I open the PR as discussion, if we really need to invoke the type loader if we already see that there's not such top level type defined.
The test is just quickly put together: if you change back to the code in master, the test throws an exception.
Let me know what you think, cheers.