Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure support for schema printer #995

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add test to ensure support for schema printer #995

merged 1 commit into from
Mar 1, 2023

Conversation

sforward
Copy link
Contributor

@sforward sforward commented Mar 1, 2023

Summary

As discussed in #953 (comment)

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

mfn
mfn approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏼

@mfn mfn merged commit e9252d8 into rebing:master Mar 1, 2023
@mfn mfn mentioned this pull request Mar 5, 2023
Closed
@sforward sforward deleted the test/print-schema branch March 6, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sforward @mfn