Specify 'subscription' as valid $operation value #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Parser::parseOperationDefinition` will create a `OperationDefinitionNode` and propagate the `operation` type it finds. In `::parseExecutableDefinition` the function is called with `query`, `mutation`, or `subscription`. This means `OperationDefinitionNode` can exist where `$operation` is `subscription`. The property type annotation doesn't currently match with this possible behaviour so we should update it :)
spawnia
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser::parseOperationDefinitionwill create aOperationDefinitionNodeand propagate the
operationtype it finds. In::parseExecutableDefinitionthe function is called with
query,mutation, orsubscription. This meansOperationDefinitionNodecan exist where$operationissubscription.The property type annotation doesn't currently match with this possible
behaviour so we should update it :)