Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object input field shortcut as callable #773

Merged
merged 1 commit into from Feb 5, 2021
Merged

Conversation

Vincz
Copy link
Contributor

@Vincz Vincz commented Feb 4, 2021

Fix error when using a callable as Input objects field type shortcut like this:

$inputObjType = new InputObjectType([
    'name'   => 'SomeInputObject',
    'fields' => [
        'f' => static function () : Type {
            return Type::string();
        },
    ],
]);

@coveralls
Copy link

coveralls commented Feb 4, 2021

Coverage Status

Coverage remained the same at 86.38% when pulling 4b5354e on Vincz:master into 115a20e on webonyx:master.

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@spawnia spawnia added the bug label Feb 4, 2021
@spawnia
Copy link
Collaborator

spawnia commented Feb 4, 2021

It would be great if you could add a line to the CHANGELOG.md

@Vincz
Copy link
Contributor Author

Vincz commented Feb 5, 2021

@spawnia Hi! Changelog has been updated as requested.

@spawnia spawnia merged commit a5712ca into webonyx:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants