Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): add webpack >= v4.0.0 (peerDependencies) #61

Closed
wants to merge 1 commit into from
Closed

fix(package): add webpack >= v4.0.0 (peerDependencies) #61

wants to merge 1 commit into from

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented Dec 7, 2017

Webpack 4 alpha has been released. In preparation for v4,
it seems reasonable to change this to allow *. This should cut
down on maintenance and avoid unnecessarily blocking folks
from updating going forward.

@lencioni
Allow any version of webpack as a peerDependency
651c184 
Webpack 4 alpha has been released. In preparation for v4,
it seems reasonable to change this to allow *. This should cut
down on maintenance and avoid unnecessarily blocking folks
from updating going forward.
@jsf-clabot
Copy link

jsf-clabot commented Dec 7, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@lencioni
Copy link
Contributor Author

lencioni commented Dec 7, 2017

Oh actually it seems that * doesn't allow pre-releases :(

@michael-ciniawsky michael-ciniawsky changed the title Allow any version of webpack as a peerDependency chore(package): allow webpack >= v4.0.0 as a peerDependency Dec 7, 2017
@michael-ciniawsky michael-ciniawsky added this to the 0.7.5 milestone Dec 7, 2017
michael-ciniawsky
michael-ciniawsky requested changes Dec 8, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick look at the code there shouldn't be anything affected by breaking changes between webpack v3.0.0...v4.0.0 in this loader. Did you test it locally within a project ?

package.json
@@ -21,7 +21,7 @@
},
"homepage": "https://github.com/webpack-contrib/expose-loader",
"peerDependencies": {
"webpack": "^2.0.0 || ^3.0.0"
"webpack": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-  "webpack": "^2.0.0 || ^3.0.0"
+ "webpack": "^2.0.0 || ^3.0.0 || ^4.0.0-alpha.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing this peerDependency altogether? I noticed that a bunch of our webpack-related dependencies have gone that route.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't decide that, but I agree that the the peerDependency is often just noise atm and maybe should just be set on loaders/plugins that really need it. On the other hand we are trying to bring in consistency across webpack-contrib about things like that, but simply aren't there yet :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @d3viant0ne

lencioni
lencioni commented Dec 8, 2017
View reviewed changes
Copy link
Contributor Author

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it out locally yet, but maybe @gdborton has?

package.json
@@ -21,7 +21,7 @@
},
"homepage": "https://github.com/webpack-contrib/expose-loader",
"peerDependencies": {
"webpack": "^2.0.0 || ^3.0.0"
"webpack": "*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing this peerDependency altogether? I noticed that a bunch of our webpack-related dependencies have gone that route.

@719media 719media mentioned this pull request Mar 2, 2018
Closed
@michael-ciniawsky michael-ciniawsky changed the title chore(package): allow webpack >= v4.0.0 as a peerDependency fix(package): add webpack >= v4.0.0 (peerDependencies) Mar 7, 2018
michael-ciniawsky
michael-ciniawsky requested changes Mar 7, 2018
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a wildcard * could you update the peerDependency on webpack to "webpack": "^2.0.0 || ^3.0.0 || ^4.0.0" please, so I can patch this package asap ? :)

@alexander-akait
Copy link
Member

@michael-ciniawsky maybe better recreate PR?

@michael-ciniawsky
Copy link
Member

Maybe yes, but wanted to give a change :P

@alexander-akait
Copy link
Member

@michael-ciniawsky let's wait to tomorrow 👍

@lencioni lencioni mentioned this pull request Mar 7, 2018
Merged
@lencioni lencioni closed this Mar 7, 2018
@lencioni lencioni deleted the patch-1 branch March 7, 2018 19:11
@michael-ciniawsky michael-ciniawsky removed this from the 0.7.5 milestone Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky requested changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

@joshwiens joshwiens Awaiting requested review from joshwiens

Assignees
No one assigned
Labels
semver: Patch status: Declined type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lencioni @jsf-clabot @alexander-akait @michael-ciniawsky