Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add watch option #157

Merged
merged 1 commit into from
Nov 27, 2017
Merged

docs(readme): add watch option #157

merged 1 commit into from
Nov 27, 2017

Conversation

BBlackwo
Copy link
Contributor

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Tests added? no
Docs updated? yes
Fixed tickets N/A
License MIT

Added watch option to readme to more explicity show that the watch options sets several defaults.

When I upgraded from 1.* to 3.* I couldn't figure out why the grunt task never finished and moved to my next task. That's because the keepalive started being defaulted to true and I didn't realise it even after reading the docs.

@jsf-clabot
Copy link

jsf-clabot commented Nov 27, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files           8        8           
  Lines         211      211           
  Branches       53       53           
=======================================
  Hits          140      140           
  Misses         58       58           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb3076...45c09c1. Read the comment docs.

@danez
Copy link
Collaborator

danez commented Nov 27, 2017

Thank you very much.

@danez danez merged commit 7c6964b into webpack-contrib:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants