chore(ci): Bring validation tooling inline with Webpack #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds editorconfig - Adds eslint package and config - Adds jsBeautify and config - Adds lint npm script - Adds beautify-lint npm script - Adds pretest npm script to exec linting - Fixes existing linting errors - Enable travis-ci node 4-6 - Add linting to CI run - Add code coverage generation & reporting
|
For reference, those tests are failing in master. I'll deal with them here. |
3 tasks
- devDependencies
- Mocha: Minor Version
- Should: MAJOR Version
- dependencies
- fastparse: Minor Version
- html-minifier: MAJOR Version
- loader-utils: Patch Version
- object-assign: Minor Version
Current coverage is 95.77% (diff: 100%)
|
|
@hemanth - This one is ready for review. You can also enable the the branch protection and set |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69
Resolves #71