fix(package): downgrade source-map v0.7.0...0.5.6
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky
changed the title
source-map v0.7.0...0.5.6
| @@ -31,7 +31,7 @@ | |||
| "async": "^2.0.0", | |||
| "loader-utils": "^1.0.0", | |||
| "lodash": "^4.0.0", | |||
| "source-map": "^0.7.0", | |||
| "source-map": "^0.5.6", | |||
There was a problem hiding this comment.
Maybe ^0.6.0 is ok here, according to the CHANGELOG support for node < v8.0.0 was drop in v0.7.0
https://github.com/mozilla/source-map/blob/master/CHANGELOG.md
Breaking change: Drop support for Node < 8. If you want to support older versions of node, please use v0.6 or below.
But the CHANGELOG sadly misses notes about the 0.6.0 release 😞, so maybe 0.5.6 is 'safer'
There was a problem hiding this comment.
I figured since the project was previously on ^0.5.6, it was safer to just revert this version bump. But I would be happy to upgrade ^0.6.0 instead.
There was a problem hiding this comment.
Yep, let's better leave it :)
|
Released in |
This was referenced Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Install breaks on node < 8
What is the new behavior?
Install is possible on node < 8
Does this PR introduce a breaking change?
Other information:
Resolves #308