Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove synchronous compilation/enhanced-require support #84

Closed
jhnns opened this issue Mar 25, 2016 · 0 comments
Closed

Remove synchronous compilation/enhanced-require support #84

jhnns opened this issue Mar 25, 2016 · 0 comments

Comments

@jhnns
Copy link
Member

jhnns commented Mar 25, 2016

We should remove the synchronous path from the less-loader. It makes the code a lot harder to understand and impairs contribution. enhanced-require is now unmaintained for 2 years and @sokra is recommending to use target: "node" in order to prepare your bundle for the server-side.

Additionally synchronous compilation is really inefficient and may slow down the application bootstrap significantly.

I've added a deprecation warning to the code so people have the chance to give us feedback. Maybe there's a use-case we haven't seen yet.

jhnns added a commit that referenced this issue Mar 7, 2017
This commit only takes the minimal actions that are required to update to webpack 2. The tests (and probably the loader itself) require more refactoring, but there's currently little time for that.

Also removed the synchronous compilation since it has been deprecated for a while: #84
@jhnns jhnns closed this as completed Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant