Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark mocha@6 compatibility and upgrade all dependencies #76

Merged
merged 7 commits into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@AviVahl
Copy link
Collaborator

AviVahl commented Dec 9, 2018

  • fixed lint warnings in EnhancedMocha.js
  • updated bundle snapshot
  • switched to @webpack-contrib/defaults

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update
  • deps upgrade (not in template)

Motivation / Use-Case

css-loader@2 came out and uses postcss@7.

Breaking Changes

css-loader has breaking changes, but it is only used to load mocha's css here, so nothing breaking is expected.

Additional Info

Upgrade all dependencies, with css-loader@2.0.0 and style-loader@0.23.1
- fixed lint warnings in EnhancedMocha.js
- updated bundle snapshot
@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Dec 9, 2018

@michael-ciniawsky, any chance you could check this out? :)

@AviVahl AviVahl changed the title Upgrade all dependencies, with css-loader@2.0.0 and style-loader@0.23.1 Upgrade all dependencies, with css-loader@2.0.1 and style-loader@0.23.1 Dec 14, 2018

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Dec 14, 2018

Upgraded to css-loader@2.0.1.

any chance someone reviews this? perhaps @evilebottnawi?

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Jan 1, 2019

Someone? Anyone?
This is the only reason all our projects have postcss@6 next to postcss@7.

Update all packages to latest versions
switch to @webpack-contrib/defaults
@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Jan 22, 2019

Updated dependencies once more. Would be awesome if this could be reviewed/merged/released.

@AviVahl AviVahl changed the title Upgrade all dependencies, with css-loader@2.0.1 and style-loader@0.23.1 Upgrade all dependencies, with css-loader@2.1.0 and style-loader@0.23.1 Jan 22, 2019

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 4, 2019

@TheLarkInn heya! any idea who do I need to mention for this to get reviewed? :)

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 5, 2019

@evilebottnawi thx for reviewing. any chance to get a release with these dep upgrades?

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 11, 2019

This is frustrating. 😞

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 18, 2019

Ping?

@tomrav

This comment has been minimized.

Copy link
Collaborator

tomrav commented Feb 25, 2019

Any chance this could merged? It's causing a lot of un-needed dependencies down the line.

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

Currently we have no active maintainers for this project. if somebody want to help us with mocha-loader please ping me and we connect in slack about future and roadmap

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 25, 2019

Both I and @tomrav are willing to keep this one maintained.
We work together at Wix.com and care about keeping this one working.

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

@AviVahl do you have rights on merge and release (github/npm)?

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 25, 2019

Not sure what you mean.
I have my github user (AviVahl) and npm user (avi.vahl).
Both are setup using two factor authentication.
I have no existing permissions to any project in the webpack/webpack-contrib organizations.

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

@AviVahl send invite, please ping me when you accept

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 25, 2019

Awesome. Accepted.
Do you guys use continuous or manual deployment to npm?

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

@AviVahl manual right now, i need you @tomrav npm nickname

@AviVahl Right now do you have ability to merge, right?

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 25, 2019

I do. Thanks.
I want to get the lock file up to date again before merging this PR.
Will also add mocha@6 to peer deps

My npm user: avi.vahl
Tom's npm user: tomrav

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

@AviVahl Can't add to npm (they still can't fix bug around adding users - user tomrav not found. (same for you), problem exists around 9 mouth), looks we need to me for release, https://npm.community/t/cant-add-collaborators-using-site-and-cli/3546

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

Just ping me when all will be done

@AviVahl AviVahl requested a review from tomrav Feb 25, 2019

@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 25, 2019

Updated all devDeps again. Also marked as compatible with mocha@6.
@tomrav can you review?

Regenerate package-lock.json with npm@6.8.0
npm@6.4.1 has a bug when generating lock file from scratch. it generates a lock file, and then a second run adds "optional" fields. newer npm fixes this issue.
@tomrav

tomrav approved these changes Feb 25, 2019

@tomrav

This comment has been minimized.

Copy link
Collaborator

tomrav commented Feb 25, 2019

Looks good to me. 👍

@AviVahl AviVahl changed the title Upgrade all dependencies, with css-loader@2.1.0 and style-loader@0.23.1 Mark mocha@6 compatibility and upgrade all dependencies Feb 25, 2019

@AviVahl AviVahl merged commit a8d3eaf into webpack-contrib:master Feb 25, 2019

1 check passed

licence/cla Contributor License Agreement is signed.
Details
@AviVahl

This comment has been minimized.

Copy link
Collaborator Author

AviVahl commented Feb 25, 2019

@evilebottnawi squashed to master. (accidentally omitted the #76 link in the commit title; sorry)
can you release a new patch version? :)

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Feb 25, 2019

👍

@evilebottnawi

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.