Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom importer #31

Closed
jhnns opened this issue Nov 10, 2014 · 8 comments
Closed

Use custom importer #31

jhnns opened this issue Nov 10, 2014 · 8 comments

Comments

@jhnns
Copy link
Member

jhnns commented Nov 10, 2014

Just wanted to point out that custom importers have been implemented with sass/libsass#21. They are currently being tested and it will take some time until node-sass provides an api, so it's still a way to go.

With custom importers we're able to plug-in webpack's resolving algorithm.

@appsforartists
Copy link

I'll be excited to see a prototype of this. I want to modularize my code into different node modules, but I can't do that if @import won't work across them.

@haustraliaer
Copy link

ohhhh great - was about to ask for this.
Will be the final cherry on top for my current react / sass / webpack workflow.

@jhnns
Copy link
Member Author

jhnns commented Dec 11, 2014

node-sass just implemented the api (sass/node-sass#530). Now we need to wait for v2 to be released.

@haustraliaer
Copy link

Which currently is waiting for a lib-sass release (sass/libsass#697) :P

Sounds like it'll all happen soon though, thank you!

@haustraliaer
Copy link

Is this now working? Or is there more to do with setting up sass-loader to @import from node_modules etc. Would be keen to test it out (I could just depend on the repo, rather than npm, I guess) if it's ready.

@jhnns
Copy link
Member Author

jhnns commented Feb 19, 2015

Is this now working?

Nope, we need to adjust the sass-loader for this. But I guess it's ready to be implemented 😬

@izaakschroeder
Copy link

@jhnns @haustraliaer see above PR.

jhnns added a commit that referenced this issue Mar 22, 2015
- Moved `node-sass^3.0.0-alpha.0` to `peerDependencies` [#28](#28)
- Using webpack's module resolver as custom importer [#39](#31)
- Add synchronous compilation support for usage with [enhanced-require](https://github.com/webpack/enhanced-require) [#39](#39)
@jhnns jhnns mentioned this issue Mar 22, 2015
@jhnns jhnns closed this as completed Mar 22, 2015
@haustraliaer
Copy link

🎉 Thanks everyone! Works like a dream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants