Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES3 parsing compatibility, Expected identifier error #362

Closed
sungkang opened this issue Jan 15, 2019 · 4 comments
Closed

ES3 parsing compatibility, Expected identifier error #362

sungkang opened this issue Jan 15, 2019 · 4 comments

Comments

@sungkang
Copy link

sungkang commented Jan 15, 2019 •
edited

Getting an "expected identifier" error in function addStyle(obj, options).

I see options.transform.default(obj.css) instead of options.transform["default"](obj.css).
This seems to break for IE8

versions:
webpack: 4.28.4
style-loader: 0.23.1
@alexander-akait
Copy link
Member

@sungkang we don't support IE8, anyway it is easy fix so PR welcome

@sungkang
Copy link
Author

sure no problem

@sungkang sungkang mentioned this issue Jan 16, 2019
Closed
@alexander-akait
Copy link
Member

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!

We drop support IE8 and IE7 for next major release

@alexander-akait
Copy link
Member

Anyway let's fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-akait @sungkang