Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed property access for ES3 compatibility #363

Closed
wants to merge 3 commits into from
Closed

changed property access for ES3 compatibility #363

wants to merge 3 commits into from

Conversation

sungkang
Copy link

What kind of change does this PR introduce?
Fixed an ES3 compatibility bug when accessing a property named "default".

Did you add tests for your changes?
No, but ran the existing tests that covered that functionality.

If relevant, did you update the README?
No

Summary
This was causing a backwards compatibility issue for applications running in IE8. The "default" property was accessed using dot notation and was changed to using square bracket notation.
Issue: #362

Does this PR introduce a breaking change?
No

@jsf-clabot
Copy link

jsf-clabot commented Jan 16, 2019

CLA assistant check
All committers have signed the CLA.

@alexander-akait
Copy link
Member

@sungkang please fix CI error

@sungkang
Copy link
Author

attempted to resolve the CI error, it first seems to be related to the Node Security Platform service shutting down and nsp check being no longer is valid.
I have resolved all the vulnerabilities from the npm audit check, but it's failing now because the Dockerfile in the CircleCI 2.0 base build container is using node version 8.11.1 which has npm5, which doesn't have the audit command. Changing that to version 10 I suppose will resolve this issue.

@alexander-akait
Copy link
Member

Close in favor #390

@alexander-akait
Copy link
Member

alexander-akait commented Jul 29, 2019

Anyway thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants