Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasise the need to override poolTimeout when watching #26

Closed
edmorley opened this issue Apr 23, 2018 · 5 comments
Closed

Emphasise the need to override poolTimeout when watching #26

edmorley opened this issue Apr 23, 2018 · 5 comments

Comments

@edmorley
Copy link

edmorley commented Apr 23, 2018

Hi!

As mentioned here, when watching is enabled (ie the development config with webpack-dev-server) the poolTimeout option should be changed from its default of 500 ms to Infinity to avoid paying the overhead of worker startup on every rebuild.

This is hinted at in a code comment of the examples section of the docs, however it seems that people aren't noticing this. eg:
facebook/create-react-app#4346
jaredpalmer/razzle#587

As such I think it would make sense to call this out explicitly in the usage section of the docs.

@alexander-akait
Copy link
Member

@edmorley PR welcome 👍

@jantimon
Copy link
Contributor

Oh - I wish I would have seen this before.
I just stumbled into the same problem:

Removing thread-loader decreased the incremental build duration by over 50% because of the booting phase of the workers.

@jantimon
Copy link
Contributor

@edmorley this is fixed with #52 :)

@alexander-akait
Copy link
Member

Done in #52

@edmorley
Copy link
Author

edmorley commented Jan 4, 2019

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants