Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread-loader's 'poolTimeout' should be overridden when watching #587

Closed
edmorley opened this issue Apr 23, 2018 · 3 comments
Closed

thread-loader's 'poolTimeout' should be overridden when watching #587

edmorley opened this issue Apr 23, 2018 · 3 comments
Labels

Comments

@edmorley
Copy link

Hi!

Currently razzle uses thread-loader to speed up babel-loader:

require.resolve('thread-loader'),

This configuration is fine in production, however as mentioned here, when watching is enabled (ie in development mode with webpack-dev-server) the poolTimeout option should be changed from its default of 500 ms to Infinity to avoid paying the overhead of worker startup on every rebuild.

See:
https://github.com/webpack-contrib/thread-loader#examples

@jaredpalmer
Copy link
Owner

Can you submit a PR?

@stale
Copy link

stale bot commented Aug 15, 2018

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

@stale stale bot added the stale label Aug 15, 2018
@stale
Copy link

stale bot commented Aug 22, 2018

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

@stale stale bot closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants