Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

test: test svg scenario. #176 #177

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

Jeff-Tian
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

There are some doubts both on stackoverflow and github(#6, wbkd/webpack-starter#2) on this package about inline svg not working. So this change added a test case for svg scenario to prove that svg indeed works here.

The value of this change is if someone met the svg not work in their project, then they can exclude the doubt of this package and go directly to spot the issues by investigating other packages.

Breaking Changes

N.A.

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Apr 1, 2019

CLA assistant check
All committers have signed the CLA.

@alexander-akait
Copy link
Member

Please accept CLA

@Jeff-Tian
Copy link
Contributor Author

@evilebottnawi thank you, accepted.

@alexander-akait alexander-akait merged commit a6705cc into webpack-contrib:master Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants