Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape embedded JS/JSON #262

Merged
merged 2 commits into from Apr 11, 2019
Merged

Properly escape embedded JS/JSON #262

merged 2 commits into from Apr 11, 2019

Conversation

@th0r
Copy link
Collaborator

@th0r th0r commented Apr 11, 2019

Don't let </script> in chartData or in internal assets break the page.

Vulnerability details: https://blog.uploadcare.com/vulnerability-in-html-design-the-script-tag-33d24642359e

@th0r th0r merged commit 3ce1b8c into master Apr 11, 2019
2 checks passed
@th0r th0r deleted the proper-js-escape branch Apr 11, 2019
@valscion
Copy link
Member

@valscion valscion commented Apr 11, 2019

This seems to have caused a regression, see #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants