Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid or unexpected token #263

Closed

Comments

@paradoxxxzero
Copy link

@paradoxxxzero paradoxxxzero commented Apr 11, 2019

Note from maintainers: Yes, we know about this regression. Avoid posting +1 comments please

This was a regression in v3.3.1. Use v3.3.2 that has a fix.


Something seems wrong with the last release (3.3.1) :

image

@valscion
Copy link
Member

@valscion valscion commented Apr 11, 2019

Have you checked that it was working with v3.3.0?

@paradoxxxzero
Copy link
Author

@paradoxxxzero paradoxxxzero commented Apr 11, 2019

Yes it works

@valscion
Copy link
Member

@valscion valscion commented Apr 11, 2019

Ok @th0r it's likely that #262 might have caused an issue. There's a strange \u003c line in the code that should be valid JS

@valscion
Copy link
Member

@valscion valscion commented Apr 11, 2019

I'm able to reproduce this on our own repository when building a static report.

Developer_Tools_-Webpack_Bundle_Analyzer-_file____Users_vesa_code_v_venuu_tmp_performance-reports_1554990096-report_html

@valscion
Copy link
Member

@valscion valscion commented Apr 11, 2019

Server build has no issues

@crazyx13th
Copy link

@crazyx13th crazyx13th commented Apr 11, 2019

grafik
same here, firefox and chrome... thx

@valscion
Copy link
Member

@valscion valscion commented Apr 11, 2019

Yup we're looking into this. This is a known regression

@th0r
Copy link
Collaborator

@th0r th0r commented Apr 11, 2019

Fixed in v3.3.2

adrw added a commit to adrw/misk-web that referenced this issue May 23, 2019
phacks added a commit to theodo/falco that referenced this issue Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment