Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use md4 instead md5 for perf reason #114

Closed
alexander-akait opened this issue May 29, 2018 · 2 comments · Fixed by #168
Closed

Use md4 instead md5 for perf reason #114

alexander-akait opened this issue May 29, 2018 · 2 comments · Fixed by #168
Labels
enhancement Help Wanted

Comments

@alexander-akait
Copy link
Member

webpack@4 already use md4 where it is possible.
@ljqx ljqx mentioned this issue Oct 9, 2018
Closed
@ljqx
Copy link
Member

ljqx commented Oct 9, 2018

Hi, @evilebottnawi , I've sent out a PR for this, could you help review?

@alexander-akait
Copy link
Member Author

@ljqx yep, PR welcome

@alexander-akait alexander-akait mentioned this issue Mar 17, 2020
Merged
apepper added a commit to Scrivito/scrivito_example_app_js that referenced this issue Mar 26, 2020
@apepper
[prerender] contentHash: md5 => md4.
4835030 
Webpack uses md4 for all hashes by default (see [1] and [2])

[1] webpack/webpack#6549
[2] webpack/loader-utils#114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Help Wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: switch to md4 by default webpack/loader-utils
2 participants
@alexander-akait @ljqx