Use MD4 for hashing #6549
Merged
Use MD4 for hashing #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much is improved? |
|
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
If you're switching hash functions, murmur2 is well-loved for a good balance between speed and uniqueness on non-cryptographic use cases. I tried looking around and couldn't find any direct comparison benchmarks though. Here's a JS implementation example: https://github.com/emotion-js/emotion/blob/master/packages/emotion-utils/src/hash.js |
|
Thanks |
|
Great idea! |
apepper
added a commit
to Scrivito/scrivito_example_app_js
that referenced
this pull request
Mar 26, 2020
Webpack uses md4 for all hashes by default (see [1] and [2]) [1] webpack/webpack#6549 [2] webpack/loader-utils#114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
build related change
Did you add tests for your changes?
yes
If relevant, link to documentation update:
n/a
Summary
md4is faster thanmd5. Since webpack doesn't need secure hashes,md4could be used to improve the build performance.Does this PR introduce a breaking change?
no