Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Regex to avoid ReDoS #222

Closed
wants to merge 1 commit into from

Conversation

jmprentice
Copy link

As described in #216 (comment), this is offered as a potential fix for the security vulnerability identified in the interpolateName.js method. I used this online ReDoS checker: https://devina.io/redos-checker

The interpolateName.js tests pass with this change, but I'm not familiar enough with the code to be sure this wouldn't introduce problems for some valid inputs.

I'm submitting PRs for all three branches because our projects need versions 2.x and 1.x (loader-utils is a transitive dependency in multiple packages).

@linux-foundation-easycla
Copy link

CLA Not Signed

@jmprentice
Copy link
Author

Handled in #226

@jmprentice jmprentice closed this Nov 11, 2022
@jmprentice jmprentice deleted the v1.0.0-branch branch November 11, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant