Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stream-http #38

Closed
feross opened this issue May 5, 2016 · 4 comments
Closed

Use stream-http #38

feross opened this issue May 5, 2016 · 4 comments

Comments

@feross
Copy link

feross commented May 5, 2016

Browserify has stopped using http-browserify and moved to stream-http which actually supports true response streaming and has lots of bug fixes.

webpack should probably switch over too.

This would fix this bug when WebTorrent is built with webpack.

cc @jhiesey

@terinjokes
Copy link
Contributor

👍 I npm installed webpack for the first time today and was shocked when I saw http-browserify still being used by node-libs-browser.

@feross
Copy link
Author

feross commented Nov 10, 2016

Can you publish this to npm so that webpack users can get the update?

@feross
Copy link
Author

feross commented Nov 12, 2016

Ping @sokra – this bug still isn't fixed in webpack because node-libs-browser was not published to npm. Can you do that real quick?

@RomanHotsiy
Copy link

@feross as a temporal workaround I'm using resolve.alias:

resolve: {
  alias: {
    http: 'stream-http',
    https: 'stream-http'
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants