Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use process start time when checking nested directory changes #178

Closed
wants to merge 1 commit into from

Conversation

Knagis
Copy link

@Knagis Knagis commented Oct 29, 2020

I honestly still have no idea which conditions exactly triggered the issue. But it was reproduced consistently - the root watcher was triggered on a change to the output folder but then the recursive check found some deep folder where it decided to compare mtime to 1 and of course always thought the folder had changed.

I am running on Windows but some colleagues using Macs reported similar issue though I haven't tested if they encountered the same problem.

Even though there likely is a more proper fix possible somewhere, this seems as a safe change to mitigate it.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #178 (46c763b) into master (c42f625) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   89.15%   89.16%   +0.01%     
==========================================
  Files           6        6              
  Lines        1051     1052       +1     
  Branches      245      245              
==========================================
+ Hits          937      938       +1     
  Misses        114      114              
Impacted Files Coverage Δ
lib/DirectoryWatcher.js 89.78% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42f625...46c763b. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@Knagis
Copy link
Author

Knagis commented Nov 20, 2020

Please add tests

unfortunately I don't know the exact scenario that triggers the issue. By the way, the root cause where I could reproduce it was already fixed by @sokra in #179, so this PR could now only serve as a mitigation for some other yet uncaught issue.

@sokra
Copy link
Member

sokra commented Nov 20, 2020

I think the PR is no longer needed as this has been fixed by the other PR

@sokra sokra closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants