fix incorrectly reported changes when attaching to an already watched directory #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
force-pushed
the
bugfix/watch-directory
branch
from
1236b80
to
0fe53cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 89.15% 91.35% +2.19%
==========================================
Files 6 6
Lines 1051 1029 -22
Branches 245 244 -1
==========================================
+ Hits 937 940 +3
+ Misses 114 89 -25
Continue to review full report at Codecov.
|
sokra
force-pushed
the
bugfix/watch-directory
branch
from
0fe53cf
to
128bcd4
Compare
|
Just tested the change and seems to have fixed the unneeded rebuild we were having. |
|
@sokra confim, webpack-contrib/copy-webpack-plugin#537 fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Knagis @evilebottnawi should fix the unnecessary invalidation with contextDependencies (hopefully)