fix: refactor redundant code

this.groups.push(GroupInstance) was common to both if and else clause added one liner ternary operation instead of if else to set mode value.
webpack · Nov 18, 2019 · c7b77a0 · c7b77a0
1 parent c193b96
commit c7b77a0
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/lib/webpack-cli.js b/lib/webpack-cli.js
@@ -81,15 +81,9 @@ class WebpackCLI extends GroupHelper {
             }
             const GroupInstance = new GroupClass(value);
             if (key === 'basic') {
-                if (GroupInstance.opts.outputOptions.dev) {
-                    mode = 'dev';
-                } else {
-                    mode = 'prod';
-                }
-                this.groups.push(GroupInstance);
-            } else {
-                this.groups.push(GroupInstance);
+                mode = GroupInstance.opts.outputOptions.dev ? 'dev' : 'prod';
             }
+            this.groups.push(GroupInstance);
         }
     }