refactor(webpack-cli): remove --no-mode flag (#1503)

Signed-off-by: Nitin Kumar <snitin315@gmail.com>
webpack · Apr 29, 2020 · dfb9a91 · dfb9a91
1 parent f6ead01
commit dfb9a91
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 92 deletions.
diff --git a/packages/webpack-cli/README.md b/packages/webpack-cli/README.md
@@ -55,7 +55,6 @@ Options
   -d, --dev                Run development build
   -p, --prod               Run production build
   --mode string            Defines the mode to pass to webpack
-  --no-mode                Sets mode="none" which disables any default behavior
   -v, --version            Get current version
   --node-args string[]     NodeJS flags
   --stats type             It instructs webpack on how to treat the stats

diff --git a/packages/webpack-cli/lib/groups/ZeroConfigGroup.js b/packages/webpack-cli/lib/groups/ZeroConfigGroup.js
@@ -20,19 +20,12 @@ class ZeroConfigGroup extends GroupHelper {
         if (process.env.NODE_ENV && (process.env.NODE_ENV === PRODUCTION || process.env.NODE_ENV === DEVELOPMENT)) {
             return process.env.NODE_ENV;
         } else {
-            // commander sets mode to false if --no-mode is specified
-            const noMode = this.args.mode === false;
-            if ((this.args.mode || noMode) && (this.args.dev || this.args.prod)) {
+            if (this.args.mode && (this.args.dev || this.args.prod)) {
                 logger.warn(
-                    `You provided both ${this.args.mode ? 'mode' : 'no-mode'} and ${
+                    `You provided both 'mode' and ${
                         this.args.prod ? '--prod' : '--dev'
-                    } arguments. You should provide just one. "${this.args.mode ? 'mode' : 'no-mode'}" will be used`,
+                    } arguments. You should provide just one. "mode" will be used`,
                 );
-                if (this.args.mode) {
-                    return this.args.mode;
-                } else {
-                    return NONE;
-                }
             }
 
             if (this.args.mode) {
@@ -46,8 +39,6 @@ class ZeroConfigGroup extends GroupHelper {
                 return PRODUCTION;
             } else if (this.args.dev) {
                 return DEVELOPMENT;
-            } else if (noMode) {
-                return NONE;
             }
             return PRODUCTION;
         }

diff --git a/packages/webpack-cli/lib/utils/cli-flags.js b/packages/webpack-cli/lib/utils/cli-flags.js
@@ -225,14 +225,6 @@ module.exports = {
             description: 'Defines the mode to pass to webpack',
             link: 'https://webpack.js.org/concepts/#mode',
         },
-        {
-            name: 'no-mode',
-            usage: '--no-mode',
-            type: Boolean,
-            group: ZERO_CONFIG_GROUP,
-            description: 'Sets mode="none" which disables any default behavior',
-            link: 'https://webpack.js.org/concepts/#mode',
-        },
         {
             name: 'version',
             usage: '--version | --version <external-package>',

diff --git a/test/no-mode/no-mode.test.js b/test/no-mode/no-mode.test.js
diff --git a/test/no-mode/src/index.js b/test/no-mode/src/index.js