-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve tests for --merge #2399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future please focus on coverage on tests which increase coverage, in future we migrate on snapshot tests with options, so it will be easy to catch problem, anyway thanks
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
=======================================
Coverage 71.74% 71.74%
=======================================
Files 47 47
Lines 2173 2173
Branches 573 573
=======================================
Hits 1559 1559
Misses 614 614 Continue to review full report at Codecov.
|
What kind of change does this PR introduce?
test
Did you add tests for your changes?
YES
If relevant, did you update the documentation?
NO
Summary
improve existing tests and add one more case for merging more than two configs.
Does this PR introduce a breaking change?
No
Other information
No