Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Use NPM CI for Tests #367

Closed
evenstensberg opened this issue Mar 24, 2018 · 2 comments
Closed

Tests: Use NPM CI for Tests #367

evenstensberg opened this issue Mar 24, 2018 · 2 comments

Comments

@evenstensberg
Copy link
Member

Do you want to request a feature or report a bug?

feature

What is the current behavior?

In our tests ( appveyor and travis ), we're using npm and not npm ci.

If the current behavior is a bug, please provide the steps to reproduce.

NPM CI is a version of npm that runs on the CI ( faster ), which will increase feedback loop.

These are the files you are most likely to revise:

Relevant Resources

What is the expected behavior?

Faster builds on integration, unit and relevant tests.

If this is a feature request, what is motivation or use case for changing the behavior?

Performance

Important

This issue is reserved for first time contributors.

Happy hacking 🎉

@FadySamirSadek
Copy link
Member

I would love to pick this one up

evenstensberg pushed a commit that referenced this issue Mar 24, 2018
* feat: use npm ci for tests

* fix(npm version): updated npm version to support npm ci

* fix(npm version): removed npm from package.json and package-lock.json
@ematipico
Copy link
Contributor

ematipico commented Mar 25, 2018

Can be closed. Thanks @FadySamirSadek !

anu-007 pushed a commit to anu-007/webpack-cli that referenced this issue Apr 8, 2018
* feat: use npm ci for tests

* fix(npm version): updated npm version to support npm ci

* fix(npm version): removed npm from package.json and package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants