feat(info): new features #1007
Merged
feat(info): new features #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@rishabh3112 could you take this out for a manual spin? |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
rishabh3112
requested changes
Jul 31, 2019
There was a problem hiding this comment.
@pranshuchittora nice work!
Did a quick black-box test on it, few things:
-
output modifiers aren't working as expected, they give the same tabular output every time.
commands I tested on
webpack-cli info ./webpack.config.js --output-markdown
webpack-cli info ./webpack.config.js --output-json -
Following commands give no output
webpack-cli info --binarieswebpack-cli info --browserswebpack-cli info --npmgwebpack-cli info --npmPackages
( Oldinfoshows me those in same project )
- Following flags are raised invalid
webpack-cli info -bwebpack-cli info -s
(--band--sare valid, but gives no output)
plus tabular output gives function definitions for options that receive a function as the value.
┌─────────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Config │ webpack.config.js │
├─────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ entry │ ./src │
├─────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ plugins │ - │
│ │ name: HtmlWebpackPlugin │
│ │ options: │
│ │ template: /webpack/play/src/index.html │
│ │ templateParameters: function templateParametersGenerator (compilation, assets, options) { │
│ │ return { │
│ │ compilation: compilation, │
│ │ webpack: compilation.getStats().toJson(), │
│ │ webpackConfig: compilation.options, │
│ │ htmlWebpackPlugin: { │
│ │ files: assets, │
│ │ options: options │
│ │ } │
│ │ }; │
│ │ } │
│ │ filename: index.html │
│ │ hash: false │
│ │ inject: true │
│ │ compile: true │
│ │ favicon: false │
│ │ minify: │
│ │ collapseWhitespace: true │
│ │ removeComments: true │
│ │ removeRedundantAttributes: true │
│ │ useShortDoctype: true │
│ │ cache: true │
│ │ showErrors: true │
│ │ chunks: all │
│ │ excludeChunks: │
│ │ (empty array) │
│ │ chunksSortMode: auto │
│ │ meta: │
│ │ title: Webpack App │
│ │ xhtml: false │
├─────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ module │ rules: │
│ │ - │
│ │ test: │
│ │ lastIndex: 0 │
│ │ use: │
│ │ - │
│ │ loader: /webpack/play/node_modules/mini-css-extract-plugin/dist/loader.js │
│ │ - css-loader │
│ │ - │
│ │ loader: postcss-loader │
│ │ options: │
│ │ ident: postcss │
│ │ plugins: │
│ │ - function creator() { │
│ │ var transformer = initializer.apply(void 0, arguments); │
│ │ transformer.postcssPlugin = name; │
│ │ transformer.postcssVersion = new _processor.default().version; │
│ │ return transformer; │
│ │ } │
│ │ - function creator() { │
│ │ var transformer = initializer.apply(void 0, arguments); │
│ │ transformer.postcssPlugin = name; │
│ │ transformer.postcssVersion = new _processor.default().version; │
│ │ return transformer; │
│ │ } │
└─────────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
|
I am not able to find the |
|
Are you able to sort this out now? If not, I can send you my setup. |
|
It's at root in |
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
evenstensberg
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of => #833
Why new PR?
Let's start fresh.