-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: help for core flags #1141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments.
@jamesgeorge007 awesome quick reviews 🐱👤👍 |
const subject = allNames.filter(name => { | ||
return args.includes(name); | ||
})[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const subject = allNames.filter(name => args.includes(name))[0];
Maybe 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little bit difficult to understand at first glance ...
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
@rishabh3112 if you resolved the conflicts, I'd say we're ready to merge it! |
@ematipico rebased, and we are ready to go I think. |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No, will need
If relevant, did you update the documentation?
No
Summary
Adds help of flags as we have help for command from #1098.
Does this PR introduce a breaking change?
No
Other information
#1098 #1053