-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better output #1196
Better output #1196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico looks much more informative now :)
Just one more issue, cli-table
seems to overflow in case of small terminal windows.
Maybe we can go with some other layout here?
@rishabh3112 I can remove the header's width so the table will be narrower: |
Honestly, I'd want to propose an argument called |
I love it!! |
@ematipico I added that change to your branch :) |
I thought and I think we can do other way around. Like add something like a |
|
So what could be a possible flag name? |
Sounds good! |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
@rishabh3112 I'd say we can make a different PR to add that new flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will take a try at it.
This looks good to me.
Thanks and Cheers! |
What kind of change does this PR introduce?
Work in progress of #717
This PR introduces the following changes:
compiler.js
=>Compiler.js
as class. I holds all the same methods as before. It also holds a classCompilerOutput.js
which is responsible to generate the wanted outputCompilerOutput.js
: this class is responsible to output based on certain options. At the moment I left the "fancy" compilation but I think this fancy way of showing the results should be "opt-in" by passing an argument. Or we should provide a way to switch back to the old output. I also prepared some other functions for emit the normal output and the JSON one.Did you add tests for your changes?
Not yet, will do
If relevant, did you update the documentation?
No, I am awaiting feedback
Summary
The output must contain at least all the information emitted by the method
stats.getOutput
.Hopefully I managed to put all of them but I need to try it with some other project.
Does this PR introduce a breaking change?
Nope
Other information