-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enhance CONTRIBUTING.md #1262
docs: enhance CONTRIBUTING.md #1262
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
b07b9f1
to
ea32ae3
Compare
@ematipico Updated 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this contribution! I would like to add a new section called "Testing the CLI locally". I can create an issue there and explain what's on my mind
ea32ae3
to
4b0e19c
Compare
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What kind of change does this PR introduce?
Made some enhancements in
CONTRIBUTING.md
.Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No