Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhance CONTRIBUTING.md #1262

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?

Made some enhancements in CONTRIBUTING.md .

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Yes
Summary
Screenshot from 2020-02-24 20-29-33

Screenshot from 2020-02-24 20-29-19

Does this PR introduce a breaking change?

No

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@snitin315
Copy link
Member Author

@ematipico Updated 👍

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution! I would like to add a new section called "Testing the CLI locally". I can create an issue there and explain what's on my mind

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice

Copy link
Contributor

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ematipico ematipico merged commit f1b7269 into webpack:next Feb 24, 2020
anshumanv pushed a commit to anshumanv/webpack-cli that referenced this pull request Feb 27, 2020
@snitin315 snitin315 deleted the chore/improve-contributing.md branch March 21, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants