Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ✏️ fix init command in README #1273

Merged
merged 1 commit into from
Feb 28, 2020
Merged

docs: ✏️ fix init command in README #1273

merged 1 commit into from
Feb 28, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?

webpack-cli create init

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
Yes
Summary

Does this PR introduce a breaking change?

No
Other information
NA

@snitin315 snitin315 requested a review from a team as a code owner February 26, 2020 14:24
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

anshumanv
anshumanv approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

godcrampy
godcrampy approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@godcrampy godcrampy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

wizardofhogwarts
wizardofhogwarts approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@ematipico ematipico merged commit 5db600c into webpack:next Feb 28, 2020
@snitin315 snitin315 deleted the fix/correct-init-readme branch February 28, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@anshumanv anshumanv anshumanv approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@mohitm15 mohitm15 mohitm15 approved these changes

@godcrampy godcrampy godcrampy approved these changes

@wizardofhogwarts wizardofhogwarts wizardofhogwarts approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@snitin315 @webpack-bot @ematipico @rishabh3112 @anshumanv @jamesgeorge007 @mohitm15 @godcrampy @wizardofhogwarts