Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos across the project #1306

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?

Fixes #1305

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
Fixed all typos.

Does this PR introduce a breaking change?

NO
Other information
NA

@snitin315 snitin315 requested a review from a team as a code owner March 9, 2020 16:38
@snitin315 snitin315 changed the title fix: typos across the project chore: fix typos across the project Mar 9, 2020
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ematipico
Copy link
Contributor

Please don't change the change logs. These are auto generated and from the commits

@snitin315 snitin315 force-pushed the fix/typo branch 2 times, most recently from 5c57adf to dd81722 Compare March 10, 2020 01:31
Copy link
Member Author

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ematipico Done 💯

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snitin315 Thanks for submitting this PR!
Have you used any tool to get these errors ( Referring to the screenshot in the corresponding issue ) ?
It would be better to automate detecting these grammatical changes by integrating it to CI.

@ematipico
Copy link
Contributor

@snitin315 Also the files under docs folder are auto generated, it doesn't help changing the typos manually

@snitin315
Copy link
Member Author

snitin315 commented Mar 10, 2020

@ematipico @rishabh3112 I used misspell to find and correct typos.

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ematipico ematipico merged commit 9933f8d into webpack:next Mar 11, 2020
@snitin315 snitin315 deleted the fix/typo branch March 14, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Typos present in the project
7 participants