Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extractSummary methods in test case #1313

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

Mistyyyy
Copy link
Contributor

What kind of change does this PR introduce?

Test cases about entry and stats

Did you add tests for your changes?

already exist

If relevant, did you update the documentation?

NA

Summary

Does this PR introduce a breaking change?

No

Other information

NA

@Mistyyyy Mistyyyy requested a review from a team as a code owner March 10, 2020 23:21
@Mistyyyy Mistyyyy changed the title Remove the extractSummary methods in test case and correct the expect value for stats cases Remove the extractSummary methods in test case Mar 10, 2020
@Mistyyyy
Copy link
Contributor Author

I think before each test run, we should clean the output info which may contain the previous test result. I encountered this problem when I run the test cases, I get the incorrect test results.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@anshumanv
Copy link
Member

Hi, thanks for your contribution.

What's the motivation for this change? Is there some discussion that I've missed? :)

@Mistyyyy
Copy link
Contributor Author

@anshumanv The discussion is here #1289

@ematipico
Copy link
Contributor

@anshumanv basically the default output of webpack is changed. That nice output should not be here in the CLI (it should be in webpack side). So in one of my previous PRs I removed moved into --pretty and doing so I had to revisit most of the tests. These ones slipped from my eyesight and this PR is to fix them!

I am going to make a new PR to remove --pretty because we don't need it.

@ematipico ematipico merged commit d2a47ef into webpack:next Mar 11, 2020
@Mistyyyy Mistyyyy deleted the fix-test-case branch March 11, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants