Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce install size #1314

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

Reduce package size

Did you add tests for your changes?

No need

If relevant, did you update the documentation?

No need

Summary

We don't use that package in our code

Does this PR introduce a breaking change?

No

Other information

We don't need extra logger because webpack has own loggers

@webpack-bot
Copy link

@evilebottnawi Please review the following output log for errors:

Worker information [...]
Build system information [...]
travis_fold:start:docker_mtu
travis_fold:end:docker_mtu
travis_fold:start:resolvconf
travis_fold:end:resolvconf


Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Setting environment variables from repository settings
$ export nproc=4

Setting environment variables from .travis.yml
$ export JOB_PART=integration


Setting up build cache [...]
 [...]
$ node --version
v10.19.0
$ npm --version
6.13.4
$ nvm --version
0.35.3
$ yarn --version
1.15.2

$ yarn travis:lint
�[2K�[1Gyarn run v1.22.4
�[2K�[1G$ yarn build && yarn lint
�[2K�[1G$ node scripts/buildPackages.js
�[2K�[1G$ /home/travis/build/webpack/webpack-cli/node_modules/.bin/tsc -b /home/travis/build/webpack/webpack-cli/packages/generate-loader /home/travis/build/webpack/webpack-cli/packages/generate-plugin /home/travis/build/webpack/webpack-cli/packages/generators /home/travis/build/webpack/webpack-cli/packages/info /home/travis/build/webpack/webpack-cli/packages/init /home/travis/build/webpack/webpack-cli/packages/logger /home/travis/build/webpack/webpack-cli/packages/migrate /home/travis/build/webpack/webpack-cli/packages/package-utils /home/travis/build/webpack/webpack-cli/packages/serve /home/travis/build/webpack/webpack-cli/packages/utils /home/travis/build/webpack/webpack-cli/packages/webpack-scaffold
 Successfully built TypeScript definition files 
�[2K�[1G$ eslint . --ext .js,.ts

/home/travis/build/webpack/webpack-cli/packages/package-utils/__tests__/index.test.ts
  10:24  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  16:29  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 2 problems (0 errors, 2 warnings)

�[2K�[1GDone in 14.41s.
The command "yarn travis:lint" exited with 0.
$ yarn test:ci
�[2K�[1Gyarn run v1.22.4
�[2K�[1G$ yarn test:cli && yarn test:packages
�[2K�[1G$ nyc jest test/ --maxWorkers=4 --reporters=default --reporters=jest-junit
 PASS  test/node/node.test.js (13.901s)
 PASS  test/no-mode/no-mode.test.js (24.312s)
 PASS  test/utils/test-utils.test.js
 PASS  test/mode/prod/prod.test.js (33.428s)
 PASS  test/output/named-bundles/output-named-bundles.test.js (20.619s)
 PASS  test/global/global.test.js (38.151s)
 PASS  test/info/info-help.test.js (17.503s)
 PASS  test/mode/dev/dev.test.js (16.498s)
 PASS  test/version/version-multi-args.test.js (16.254s)
 PASS  test/help/help-single-arg.test.js (13.679s)
 PASS  test/defaults/output-defaults.test.js (16.999s)
 PASS  test/serve/serve-basic.test.js (25.34s)
 PASS  test/stats/stats.test.js (42.154s)
 PASS  test/info/info-output.test.js (23.071s)
 PASS  test/help/help-flags.test.js (9.958s)
 PASS  test/help/help-commands.test.js (10.03s)
 PASS  test/source-map/object/source-map-object.test.js (14.911s)
 PASS  test/info/info-multi-args.test.js (20.287s)
 PASS  test/merge/defaults/merge-defaults.test.js (9.531s)
 PASS  test/help/help-multi-args.test.js (9.707s)
 PASS  test/env/prod/prod.test.js (10.601s)
 PASS  test/entry/defaults-index/entry-multi-args.test.js (10s)
 FAIL  test/entry/config-entry/entry-with-command/entry-with-command.test.js
  ● config entry and command entry all exist › should use command entry if config command existed

    expect(received).toContain(expected) // indexOf

    Matcher error: received value must not be null nor undefined

    Received has value: undefined

       9 |         const summary = extractSummary(stdout);
      10 |         const outputDir = 'entry-with-command/binary';
    > 11 |         expect(summary['Output Directory']).toContain(outputDir);
         |                                             ^
      12 | 
      13 |         expect(stdout).toContain('./index.js');
      14 |         stat(resolve(__dirname, './binary/main.bundle.js'), (err, stats) => {

      at Object.done (test/entry/config-entry/entry-with-command/entry-with-command.test.js:11:45)

 PASS  test/source-map/array/source-map-array.test.js (10.598s)
 PASS  test/env/array/array-env.test.js (14.759s)
 PASS  test/typescript/typescript.test.js (12.008s)
 PASS  test/config-lookup/dotfolder-array/dotfolder-array.test.js (5.021s)
 FAIL  test/entry/config-entry/entry-with-config/entry-with-config.test.js
  ● default entry and config entry all exist › should use config entry if config entry existed

    expect(received).toContain(expected) // indexOf

    Matcher error: received value must not be null nor undefined

    Received has value: undefined

       9 |         const summary = extractSummary(stdout);
      10 |         const outputDir = 'entry-with-config/binary';
    > 11 |         expect(summary['Output Directory']).toContain(outputDir);
         |                                             ^
      12 | 
      13 |         expect(stdout).toContain('./a.js');
      14 |         stat(resolve(__dirname, './binary/index.bundle.js'), (err, stats) => {

      at Object.done (test/entry/config-entry/entry-with-config/entry-with-config.test.js:11:45)

 PASS  test/env/object/object-env.test.js (10.332s)
 PASS  test/config/basic/basic-config.test.js
 PASS  test/config/type/array/array-config.test.js (5.08s)
 PASS  test/config-lookup/dotfolder-single/dotfolder-single.test.js
 PASS  test/merge/config/merge-config.test.js
 PASS  test/defaults/without-config-and-entry/default-without-config.test.js
 PASS  test/config/type/function/function-config.test.js
 PASS  test/version/version-single-arg.test.js (6.806s)
 PASS  test/target/node/node-test.test.js
 PASS  test/output/pretty/pretty.test.js
 PASS  test/standard/standard.test.js
 PASS  test/config/empty/empty-config.test.js
 PASS  test/entry/scss/scss.test.js (7.108s)
 PASS  test/unknown/unknown.test.js
 PASS  test/entry/defaults-empty/entry-single-arg.test.js
�[999D�[K
Summary of all failing tests
 FAIL  test/entry/config-entry/entry-with-command/entry-with-command.test.js
  ● config entry and command entry all exist › should use command entry if config command existed

    expect(received).toContain(expected) // indexOf

    Matcher error: received value must not be null nor undefined

    Received has value: undefined

       9 |         const summary = extractSummary(stdout);
      10 |         const outputDir = 'entry-with-command/binary';
    > 11 |         expect(summary['Output Directory']).toContain(outputDir);
         |                                             ^
      12 | 
      13 |         expect(stdout).toContain('./index.js');
      14 |         stat(resolve(__dirname, './binary/main.bundle.js'), (err, stats) => {

      at Object.done (test/entry/config-entry/entry-with-command/entry-with-command.test.js:11:45)

 FAIL  test/entry/config-entry/entry-with-config/entry-with-config.test.js
  ● default entry and config entry all exist › should use config entry if config entry existed

    expect(received).toContain(expected) // indexOf

    Matcher error: received value must not be null nor undefined

    Received has value: undefined

       9 |         const summary = extractSummary(stdout);
      10 |         const outputDir = 'entry-with-config/binary';
    > 11 |         expect(summary['Output Directory']).toContain(outputDir);
         |                                             ^
      12 | 
      13 |         expect(stdout).toContain('./a.js');
      14 |         stat(resolve(__dirname, './binary/index.bundle.js'), (err, stats) => {

      at Object.done (test/entry/config-entry/entry-with-config/entry-with-config.test.js:11:45)


Test Suites: 2 failed, 3 skipped, 41 passed, 43 of 46 total
Tests:       2 failed, 3 skipped, 111 passed, 116 total
Snapshots:   0 total
Time:        135.459s
Ran all test suites matching /test\//i.
�[2K�[1Gerror Command failed with exit code 1.
�[2K�[1Ginfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
�[2K�[1Gerror Command failed with exit code 1.
�[2K�[1Ginfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn test:ci" exited with 1.
store build cache [...]

Done. Your build exited with 1.

See complete report here.

@alexander-akait
Copy link
Member Author

@ematipico Do we already have a PR with fix tests?

@ematipico ematipico merged commit 1648f34 into webpack:next Mar 11, 2020
@alexander-akait alexander-akait deleted the chore-reduce-install-side branch March 11, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants