-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce install size #1314
Merged
ematipico
merged 1 commit into
webpack:next
from
alexander-akait:chore-reduce-install-side
Mar 11, 2020
Merged
chore: reduce install size #1314
ematipico
merged 1 commit into
webpack:next
from
alexander-akait:chore-reduce-install-side
Mar 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@evilebottnawi Please review the following output log for errors:
See complete report here. |
ematipico
approved these changes
Mar 11, 2020
@ematipico Do we already have a PR with fix tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Reduce package size
Did you add tests for your changes?
No need
If relevant, did you update the documentation?
No need
Summary
We don't use that package in our code
Does this PR introduce a breaking change?
No
Other information
We don't need extra logger because webpack has own loggers