Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add core-team link to CODE_OF_CONDUCT.md #1329

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

Parikshit-Hooda
Copy link
Contributor

What kind of change does this PR introduce?
docs: add a missing link to code_of_conduct.md

Did you add tests for your changes?
not required.

If relevant, did you update the documentation?
not required.

Summary
add https://github.com/orgs/webpack/teams/core-team to @webpack-core phrase

motivation: missing link fix.

Does this PR introduce a breaking change?

no

Other information
resolves #1328

docs: add core-team link to CODE_OF_CONDUCT.md

add https://github.com/orgs/webpack/teams/core-team to @webpack-core phrase

resolves webpack#1328
@Parikshit-Hooda Parikshit-Hooda requested a review from a team as a code owner March 17, 2020 07:17
@jsf-clabot
Copy link

jsf-clabot commented Mar 17, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@anshumanv
Copy link
Member

You can also make it bold like it's done for the cli-team

@snitin315
Copy link
Member

https://github.com/orgs/webpack/teams/core-team

Do we have to a member of team to access the link? It's giving me a 404 error.

@anshumanv
Copy link
Member

Do we have to a member of team to access the link? It's giving me a 404 error.

I think you need to be a member of the org to access teams, in that case not sure if it makes sense to linkify the team links since outsiders won't be able to access them.

@alexander-akait alexander-akait merged commit f5ce7a2 into webpack:next Mar 17, 2020
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core-team link in CODE_OF_CONDUCT not present
6 participants