chore: fix eslint configuration #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
approved these changes
Mar 18, 2020
anshumanv
approved these changes
Mar 18, 2020
| @@ -1,4 +1,4 @@ | |||
| module.exports = { | |||
| root: false, | |||
| parserOptions: { ecmaVersion: 2020, sourceType: 'module' }, | |||
| parserOptions: { ecmaVersion: 2020, sourceType: 'script' }, | |||
There was a problem hiding this comment.
script is default, removing also works
There was a problem hiding this comment.
Default root config contains parserOptions: { ecmaVersion: 2020, sourceType: 'module' }, so I override it, in future we should revisit eslint configuration, I think now we can avoid it to continue development
ryanclark
approved these changes
Mar 18, 2020
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
rishabh3112
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
No need
If relevant, did you update the documentation?
No
Summary
For #1345
Does this PR introduce a breaking change?
No
Other information
webpack-cli package do not use modules, don't know why we use that configuration