-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logger): remove logger package, inline webpack logger #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI under maintenance, LGTM
298842c
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team need more reviews
@evilebottnawi rebased which removed your review, PTAL again. ✨ |
/cc @webpack/cli-team need more reviews |
PTAL @evilebottnawi @rishabh3112, let's get this in. 🌟 |
Uhoh, taking look at tests. |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
@@ -1,3 +1,3 @@ | |||
const { logger } = require('@webpack-cli/logger'); | |||
const { getLogger } = require('webpack/lib/logging/runtime'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webpack/lib/logging/runtime
should not be used here. Use compiler.getInfrastructureLogger("webpack-cli")
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sokra we use logging before run webpack and after, and when we do other actions which don't need webpack (like init
/info
/migrate
/generate
), so we can't use infrastructure logger
What kind of change does this PR introduce?
Remove logger package.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No
Other information
NA