Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm unused packages #1376

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Mar 25, 2020

What kind of change does this PR introduce?
rm unused deps, move common dev deps to root.

Did you add tests for your changes?
Not needed.

If relevant, did you update the documentation?
Not needed.

Summary

  • Removed unused deps.

Does this PR introduce a breaking change?
No

Other information
#1339 (comment)

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

/cc @webpack/cli-team need more reviews

@anshumanv
Copy link
Member Author

Travis is giving trouble 😕

@alexander-akait
Copy link
Member

@anshumanv Travis is slow, because every hour somebody push update to master, do not push on it every time, you need push it only before merging

@anshumanv
Copy link
Member Author

Yeah seems like, sounds good. 👍

@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants