Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improving init and migrate #1379

Merged
merged 8 commits into from
Jun 30, 2020
Merged

docs: improving init and migrate #1379

merged 8 commits into from
Jun 30, 2020

Conversation

himanshu010
Copy link
Contributor

@himanshu010 himanshu010 commented Mar 26, 2020

What kind of change does this PR introduce?

docs related change
Did you add tests for your changes?

If relevant, did you update the documentation?
N/A
Summary
N/A

Does this PR introduce a breaking change?

Other information

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

alexander-akait
alexander-akait previously approved these changes Apr 1, 2020
jeffin143
jeffin143 previously approved these changes Apr 2, 2020
Copy link
Contributor

@jeffin143 jeffin143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and merge this :)


1. `Will your application have multiple bundles? (y/N)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this.

@snitin315 snitin315 merged commit 29c8b40 into webpack:next Jun 30, 2020
@snitin315
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants